Skip to content

impl(auth): make TokenProviderWithRetry RefUnwindSafe #4447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alvarowolfx merged 2 commits into from
Jan 30, 2026
Merged

impl(auth): make TokenProviderWithRetry RefUnwindSafe #4447

alvarowolfx merged 2 commits into from
Jan 30, 2026
+20 −0

Conversation

@alvarowolfx
Copy link
Collaborator

@alvarowolfx alvarowolfx commented Jan 29, 2026

The TokenProviderWithRetry struct was not implementing RefUnwindSafe because it held Arc<dyn RetryPolicy> and Arc<dyn BackoffPolicy>, which are trait objects that do not automatically implement RefUnwindSafe.

When TokenProviderWithRetry was embedded into other public structs (like IDTokenCredentials), those structs also lost their RefUnwindSafe implementation. This caused a semantic versioning check failure as RefUnwindSafe is part of the public API promise.

Towards #3592

@alvarowolfx alvarowolfx requested a review from coryan January 29, 2026 17:42
@alvarowolfx alvarowolfx requested review from a team as code owners January 29, 2026 17:42
@alvarowolfx
Copy link
Collaborator Author

alvarowolfx commented Jan 29, 2026

unblocks #4260, #4257 and #4256

@codecov
Copy link

codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.04%. Comparing base (90873cc) to head (5a08453).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4447   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         194      194           
  Lines        7372     7372           
=======================================
  Hits         7007     7007           
  Misses        365      365

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coryan
coryan reviewed Jan 29, 2026
View reviewed changes
@alvarowolfx
Copy link
Collaborator Author

alvarowolfx commented Jan 30, 2026 •
edited
Loading

@coryan I've updated this PR based on your comments on #4256

@alvarowolfx alvarowolfx enabled auto-merge (squash) January 30, 2026 16:44
@alvarowolfx alvarowolfx merged commit 574ce77 into googleapis:main Jan 30, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alvarowolfx @coryan